Skip to content

Add attribution objective outcome and snapshot contracts#79

Merged
haasonsaas merged 2 commits intomainfrom
codex/attribution-objective-snapshots
Apr 15, 2026
Merged

Add attribution objective outcome and snapshot contracts#79
haasonsaas merged 2 commits intomainfrom
codex/attribution-objective-snapshots

Conversation

@haasonsaas
Copy link
Copy Markdown
Contributor

Summary

  • extend the attribution contract with objective outcome support
  • add signal-driven snapshot APIs for objective and trace completion events
  • generate updated Go, TS, and Python attribution bindings

Validation

  • buf lint
  • buf generate --path proto/attribution/v1/attribution.proto --timeout 10m
  • go test ./... -count=1
  • npm ci
  • npm run check:package

@cursor
Copy link
Copy Markdown

cursor bot commented Apr 15, 2026

PR Summary

Medium Risk
Expands public protobuf contracts and service RPC surface (new messages/enums and new RPCs), which may require coordinated client/server updates and careful backward-compatibility checks.

Overview
Extends the attribution.v1 contract to support objective outcome attribution by adding ObjectiveContext, objective-scoped summaries, and wiring these into AttributionQuery, AttributionReport, and AttributionReportSummary.

Adds a new signal-driven snapshot model: AttributionSnapshot, AttributionSignal (+ completion signal variants), and new service RPCs RecordSignals, GetSnapshot, and ListSnapshots with filtering by AttributionSubjectKind.

Updates generated Go and Python bindings (including Connect clients/handlers) for both AttributionService and EntityService, and adds MergeEntities/SplitEntity RPC contracts with supporting request/response types.

Reviewed by Cursor Bugbot for commit ad17453. Bugbot is set up for automated code reviews on this repo. Configure here.

@haasonsaas haasonsaas merged commit 62ad69a into main Apr 15, 2026
7 checks passed
@haasonsaas haasonsaas deleted the codex/attribution-objective-snapshots branch April 15, 2026 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant