Skip to content

Add notifications templates and category-aware routing contract#81

Merged
haasonsaas merged 1 commit intomainfrom
codex/notifications-templates
Apr 15, 2026
Merged

Add notifications templates and category-aware routing contract#81
haasonsaas merged 1 commit intomainfrom
codex/notifications-templates

Conversation

@haasonsaas
Copy link
Copy Markdown
Contributor

Summary

  • add notification categories, category channel preferences, and template messages/RPCs
  • extend SendRequest and Notification with category/template fields
  • regenerate Go, Python, and TypeScript notifications bindings

Testing

  • buf lint
  • go test ./... -count=1
  • npm ci
  • npm run check:package

@cursor
Copy link
Copy Markdown

cursor bot commented Apr 15, 2026

PR Summary

Medium Risk
Medium risk because it expands the public notifications proto/API (new fields, messages, and RPCs), requiring coordinated server/client updates and potential backward-compatibility considerations for older clients.

Overview
Adds a new NotificationCategory enum and extends Notification/SendRequest with category plus template-related fields (template_name, template_variables_json) to support category-aware routing and templated notifications.

Introduces per-category channel overrides via CategoryChannelPreference on NotificationPreferences, and adds NotificationTemplate plus new UpsertTemplate and ListTemplates RPCs. Regenerates Go, Python, and TypeScript/Connect generated bindings to reflect the updated proto contract.

Reviewed by Cursor Bugbot for commit 20450f3. Bugbot is set up for automated code reviews on this repo. Configure here.

@haasonsaas haasonsaas merged commit 2fa442b into main Apr 15, 2026
6 checks passed
@haasonsaas haasonsaas deleted the codex/notifications-templates branch April 15, 2026 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant