You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Medium Risk
Medium risk because it expands the public notifications proto/API (new fields, messages, and RPCs), requiring coordinated server/client updates and potential backward-compatibility considerations for older clients.
Overview
Adds a new NotificationCategory enum and extends Notification/SendRequest with category plus template-related fields (template_name, template_variables_json) to support category-aware routing and templated notifications.
Introduces per-category channel overrides via CategoryChannelPreference on NotificationPreferences, and adds NotificationTemplate plus new UpsertTemplate and ListTemplates RPCs. Regenerates Go, Python, and TypeScript/Connect generated bindings to reflect the updated proto contract.
Reviewed by Cursor Bugbot for commit 20450f3. Bugbot is set up for automated code reviews on this repo. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SendRequestandNotificationwith category/template fieldsTesting