You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Apr 16, 2026. It is now read-only.
make the tap server shutdown timeout configurable instead of hardcoding 10s
add a charts/siphon/values-production.yaml profile that enables HPA by default for production installs
extend chart/config validation to cover the new server field and production profile rendering
Why
This is a bounded first slice of #19 covering the operational improvements only. It leaves the audit integration and protobuf publisher migration untouched.
Validation
go test ./config ./cmd/tap -count=1
direct runtime config surface validation for config.example.yaml and Helm-rendered config.yaml
bash scripts/assert-chart-render.sh
helm lint charts/siphon
go test ./... -count=1
go test ./... -race -count=1
go vet ./...
git diff --check
Notes
./scripts/lint-config.sh still uses Bash 4 lowercase expansion and fails on macOS's stock Bash 3, so I ran the script's underlying validation steps directly locally. CI runs on Ubuntu and is unaffected.
Medium Risk
Operational/config changes that affect shutdown behavior and Helm autoscaling defaults; misconfiguration could impact rollout/shutdown characteristics but does not touch security-critical logic.
Overview
Makes HTTP shutdown draining configurable by introducing server.shutdown_timeout (wired from config/env/Helm, defaulting to 10s) and using it instead of a hardcoded 10s in cmd/tap/run.go.
Adds a Helm production profile via charts/siphon/values-production.yaml that enables autoscaling (HPA) by default, updates chart schema/docs/config examples accordingly, and extends tests/scripts to validate the new config field and that the production profile renders an HPA and omits fixed deployment replicas.
Reviewed by Cursor Bugbot for commit 5de3ee7. Bugbot is set up for automated code reviews on this repo. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
charts/siphon/values-production.yamlprofile that enables HPA by default for production installsWhy
This is a bounded first slice of
#19covering the operational improvements only. It leaves the audit integration and protobuf publisher migration untouched.Validation
go test ./config ./cmd/tap -count=1config.example.yamland Helm-renderedconfig.yamlbash scripts/assert-chart-render.shhelm lint charts/siphongo test ./... -count=1go test ./... -race -count=1go vet ./...git diff --checkNotes
./scripts/lint-config.shstill uses Bash 4 lowercase expansion and fails on macOS's stock Bash 3, so I ran the script's underlying validation steps directly locally. CI runs on Ubuntu and is unaffected.