Skip to content
This repository was archived by the owner on Apr 16, 2026. It is now read-only.

[codex] add siphon operational production profile#33

Merged
haasonsaas merged 1 commit intomainfrom
codex/siphon-operational-improvements
Apr 16, 2026
Merged

[codex] add siphon operational production profile#33
haasonsaas merged 1 commit intomainfrom
codex/siphon-operational-improvements

Conversation

@haasonsaas
Copy link
Copy Markdown
Contributor

Summary

  • make the tap server shutdown timeout configurable instead of hardcoding 10s
  • add a charts/siphon/values-production.yaml profile that enables HPA by default for production installs
  • extend chart/config validation to cover the new server field and production profile rendering

Why

This is a bounded first slice of #19 covering the operational improvements only. It leaves the audit integration and protobuf publisher migration untouched.

Validation

  • go test ./config ./cmd/tap -count=1
  • direct runtime config surface validation for config.example.yaml and Helm-rendered config.yaml
  • bash scripts/assert-chart-render.sh
  • helm lint charts/siphon
  • go test ./... -count=1
  • go test ./... -race -count=1
  • go vet ./...
  • git diff --check

Notes

./scripts/lint-config.sh still uses Bash 4 lowercase expansion and fails on macOS's stock Bash 3, so I ran the script's underlying validation steps directly locally. CI runs on Ubuntu and is unaffected.

@cursor
Copy link
Copy Markdown

cursor bot commented Apr 16, 2026

PR Summary

Medium Risk
Operational/config changes that affect shutdown behavior and Helm autoscaling defaults; misconfiguration could impact rollout/shutdown characteristics but does not touch security-critical logic.

Overview
Makes HTTP shutdown draining configurable by introducing server.shutdown_timeout (wired from config/env/Helm, defaulting to 10s) and using it instead of a hardcoded 10s in cmd/tap/run.go.

Adds a Helm production profile via charts/siphon/values-production.yaml that enables autoscaling (HPA) by default, updates chart schema/docs/config examples accordingly, and extends tests/scripts to validate the new config field and that the production profile renders an HPA and omits fixed deployment replicas.

Reviewed by Cursor Bugbot for commit 5de3ee7. Bugbot is set up for automated code reviews on this repo. Configure here.

@haasonsaas haasonsaas marked this pull request as ready for review April 16, 2026 00:17
@haasonsaas haasonsaas merged commit 3695a93 into main Apr 16, 2026
19 checks passed
@haasonsaas haasonsaas deleted the codex/siphon-operational-improvements branch April 16, 2026 01:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant