Remove duplicate chat plugin#7
Open
evanklem wants to merge 2 commits into
Open
Conversation
The chat plugin ships as a built-in under plugins/chat/, but an identical copy was also sitting in .polypore/plugins/polypore.chat/ — the registry for user-installed plugins. Built-ins are bundled, not installed, so the registry copy is redundant and creates a duplicate polypore.chat id. Drop it; the built-in remains the sole source. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Built-in plugins ship in plugins/; the .polypore/plugins/ registry only holds installed copies, which the mcp:pipeline-smoke run recreates on every invocation. Tracking it is what let a duplicate polypore.chat get committed. Ignore the whole registry so smoke runs no longer dirty the working tree. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
Removes the redundant
polypore.chatcopy committed under.polypore/plugins/, which is the install registry for user-installed plugins. The plugin already ships as a built-in underplugins/chat/.Also adds
/.polypore/plugins/to.gitignoresomcp:pipeline-smoke, which installs the plugin there on every run, no longer dirties the working tree or lets the duplicate get re-committed.Closes #6
How to test
Run
mcp:pipeline-smoke.polypore.chatunder.polypore/plugins/, but that generated copy should remain ignored by Git.Confirm the built-in plugin still exists under
plugins/chat/.Confirm the working tree stays clean after the smoke test.
Checklist
cargo clippy --no-deps -- -D warnings— N/A, no Rust changed.gitignorechange onlygit statusis clean after runningmcp:pipeline-smoke