Various fixes and improvements to robustness#2
Open
MaddieM4 wants to merge 3 commits intoevanw:masterfrom
Open
Various fixes and improvements to robustness#2MaddieM4 wants to merge 3 commits intoevanw:masterfrom
MaddieM4 wants to merge 3 commits intoevanw:masterfrom
Conversation
Owner
|
I'm sorry but I can't seem to get this working. I think socket.io changed their API again so the library and tests are no longer valid. I'm glad you found this useful but I'm considering this project a failed experiment at this point. |
Author
|
It works for me, but only with certain versions of Socket.IO and Node.JS. Do you mind if I continue to maintain my repository for the project, and maybe bring it up to date with the new API? |
Owner
|
Sure, I would be glad to know when you bring it up to date with the current socket.io API. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm using your library in a program that has to do a bunch of stuff other than Socket.IO hosting at the same time, and I made some changes to get it to work. Plus a bit of error handling from when I had the wrong version of node installed, and the errors were hijacking the whole process. I figured these fixes would be useful to the general public as well, so I'm putting them here. Be sure to test it out on your own machine first to make sure they don't just work on mine (certainly a possibility).