Skip to content

chore: bump ship-go to fork commit fixing trusted-reconnect mDNS cancel#31626

Closed
andig wants to merge 1 commit into
masterfrom
chore/bump-ship-go-trusted-reconnect
Closed

chore: bump ship-go to fork commit fixing trusted-reconnect mDNS cancel#31626
andig wants to merge 1 commit into
masterfrom
chore/bump-ship-go-trusted-reconnect

Conversation

@andig

@andig andig commented Jul 9, 2026

Copy link
Copy Markdown
Member

pairs with enbility/ship-go#89

Points at andig/ship-go@4d894c216: a trusted/paired device's pending reconnect no longer gets cancelled by a transient mDNS drop, which stranded EEBus reconnects after a controller restart and was one of the causes behind the flaky TestShipPairing (#31534, #31570).

🤖 Generated with Claude Code

Points at andig/ship-go@4d894c216 (enbility/ship-go#89): a trusted/paired
device's pending reconnect no longer gets cancelled by a transient mDNS
drop, which stranded EEBus reconnects after a controller restart and was
one of the causes behind the flaky TestShipPairing (#31534, #31570).

Interim fork pin until enbility/ship-go#89 merges to dev, at which point
this should be flipped to the clean upstream pseudo-version.

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • Consider adding a brief comment or TODO next to the new ship-go replace in go.mod indicating that it should be reverted to the upstream module once enbility/ship-go#89 is merged, so this temporary fork pin is easy to track.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Consider adding a brief comment or TODO next to the new ship-go replace in go.mod indicating that it should be reverted to the upstream module once enbility/ship-go#89 is merged, so this temporary fork pin is easy to track.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@andig andig closed this Jul 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant