chore: bump ship-go to fork commit fixing trusted-reconnect mDNS cancel#31626
Closed
andig wants to merge 1 commit into
Closed
chore: bump ship-go to fork commit fixing trusted-reconnect mDNS cancel#31626andig wants to merge 1 commit into
andig wants to merge 1 commit into
Conversation
Points at andig/ship-go@4d894c216 (enbility/ship-go#89): a trusted/paired device's pending reconnect no longer gets cancelled by a transient mDNS drop, which stranded EEBus reconnects after a controller restart and was one of the causes behind the flaky TestShipPairing (#31534, #31570). Interim fork pin until enbility/ship-go#89 merges to dev, at which point this should be flipped to the clean upstream pseudo-version.
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Consider adding a brief comment or TODO next to the new ship-go replace in go.mod indicating that it should be reverted to the upstream module once enbility/ship-go#89 is merged, so this temporary fork pin is easy to track.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider adding a brief comment or TODO next to the new ship-go replace in go.mod indicating that it should be reverted to the upstream module once enbility/ship-go#89 is merged, so this temporary fork pin is easy to track.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pairs with enbility/ship-go#89
Points at
andig/ship-go@4d894c216: a trusted/paired device's pending reconnect no longer gets cancelled by a transient mDNS drop, which stranded EEBus reconnects after a controller restart and was one of the causes behind the flakyTestShipPairing(#31534, #31570).dev, at which point this should be flipped to the clean upstream pseudo-version.TestShipPairingrestart/reconnect: 5/5 clean with this bump, vs a ~3/8 baseline failure rate before it.🤖 Generated with Claude Code