Dockerfile: fix broken docker build#32101
Closed
github-actions[bot] wants to merge 3 commits into
Closed
Conversation
Contributor
|
To be able to build the docker image, I had to made the following changes: |
npm run build regenerates the openapi spec from the go sources, which are not present in the node stage. Run vite build directly and drop the make install plus Makefile copy that were only needed for it. Also ignore local tooling dirs in the docker build context.
npm run build also runs the openapi generator, which needs tsconfig.json, scripts/ and the server/*.yaml specs plus an existing server/mcp folder for its output. Copy them into the node stage instead of bypassing make.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #32100
Docker builds from
masterwere broken in two places:cmd/openapi/openapi.gowas removed in API: generate /api/state documentation from UI types #31530 (replaced by the external toolgithub.com/evcc-io/openapi-mcp/cmd/openapi-mcp, now declared ingo.mod'stool (...)block), butDockerfilestill hadCOPY cmd/openapi/ cmd/openapi/, referencing a directory that no longer exists.cmd/implement/(still a local-module tool) remains copied as before.make uiin the node stage runsnpm run build, which since API: generate /api/state documentation from UI types #31530 also runs the openapi generator. That generator needstsconfig.json,scripts/and theserver/*.yamlspecs, none of which were copied into the node stage. They are now, together with anmkdirfor the generator'sserver/mcpoutput folder.Also added local tooling directories and
*.dbto.dockerignoreto keep them out of the build context.🤖 Generated with Claude Code