Revert "API: generate /api/state documentation from UI types"#32109
Merged
Conversation
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- In cmd/openapi/openapi.go, consider validating os.Args length and printing a helpful usage message instead of assuming two arguments are always present to avoid cryptic panics when invoked incorrectly.
- Several TS interfaces in evcc.ts were relaxed or changed (e.g. InfluxConfig.database/org now
any,modbusproxyandmessagingEventsno longer allownull); double-check these against the actual /api/state payload so the UI types still accurately represent nullable fields and avoid unnecessaryanyusage.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- In cmd/openapi/openapi.go, consider validating os.Args length and printing a helpful usage message instead of assuming two arguments are always present to avoid cryptic panics when invoked incorrectly.
- Several TS interfaces in evcc.ts were relaxed or changed (e.g. InfluxConfig.database/org now `any`, `modbusproxy` and `messagingEvents` no longer allow `null`); double-check these against the actual /api/state payload so the UI types still accurately represent nullable fields and avoid unnecessary `any` usage.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #31530 (commit 542a01f).
Follow-up changes on top of it are kept:
batteryGridDischargesetting (types, openapi path)dischargebattery suggestion actionserver/mcp/openapi.jsonandserver/mcp/openapi.mdare regenerated with the restoredgo tool openapigenerator.🤖 Generated with Claude Code