Fix generated ruleset and FT stylesheet rewrite#12
Open
andesco wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR fixes and hardens ruleset behavior by correcting YAML formatting/typos and making the FT stylesheet “de-proxy” logic safer.
Changes:
- Guard against missing
hrefand only de-proxy proxied stylesheet URLs to avoid breaking absolute URLs. - Fix a typo in the
user-agentheader key. - Fix/clean YAML test list indentation and remove trailing whitespace.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| rulesets/gb/ft-com.yaml | Makes the FT stylesheet URL rewrite conditional and null-safe; fixes test indentation. |
| ruleset.yaml | Fixes user-agent header typo, corrects YAML test list formatting, and aligns FT rewrite logic. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+235
to
+239
| // Only de-proxy stylesheet URLs ("/https://...") to avoid breaking absolute "https://..." hrefs. | ||
| if (href.startsWith('/https://') || href.startsWith('/http://')) { | ||
| const updatedHref = href.slice(1).replace(/(https?:\/\/.+?)\/{2,}/, '$1/'); | ||
| el.setAttribute('href', updatedHref); | ||
| } |
| if (!href) return; | ||
| // Only de-proxy stylesheet URLs ("/https://...") to avoid breaking absolute "https://..." hrefs. | ||
| if (href.startsWith('/https://') || href.startsWith('/http://')) { | ||
| const updatedHref = href.slice(1).replace(/(https?:\/\/.+?)\/{2,}/, '$1/'); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation