fix(thrift): use standard XOR zigzag decode to fix numeric message offset#201
Merged
Conversation
The multiplication-based zigzag formula `(n >> 1) * (sign)` produced an off-by-one for every negative value (odd encoded integers), causing numeric-only message text to arrive with a +1…+3 offset that grew with batch size. Switching both `decodeZigZag` and the type-16 string-ID delta to the canonical `(n >> 1) ^ -(n & 1)` fixes the accumulation error. Closes #200 Co-authored-by: pchrphhee <pchrphhee@users.noreply.github.com>
Member
Author
|
thanks you @pchrphhee |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TMoreCompactProtocol.decodeZigZag()which used a multiplication-based formula(n >> 1) * (sign)instead of the standard XOR formula(n >> 1) ^ -(n & 1). The old formula was off by +1 for every negative value (odd encoded integers).lastStringIdaccumulates across the entire parse, each negative delta error compounded — causing numeric-only message text (e.g. "100") to arrive as "101", "102", or "103".decodeZigZagcovering positive values, negative values, and round-trip with standard zigzag encoding.Closes #200
Test plan
deno test packages/linejs/base/thrift/readwrite/tmc.test.tspasses (3 tests)deno checkpassesdeno fmtpassesmessage.textmatches exactly🤖 Generated with Claude Code
Co-authored-by: pchrphhee pchrphhee@users.noreply.github.com