refactor: extract golden snapshot regeneration + auto-fix in pre-commit#53
Merged
Conversation
- New: scripts/regenerate-golden-snapshots.py (single source of truth) - release-preflight.sh: auto-regenerate stale snapshots during pre-commit - release-sync.sh: replace 48-line inline Python with script call - .githooks/pre-commit: stage golden-snapshots.json after version bump - Graceful ImportError skip for test fixture environments Context-Checkpoint: B
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
release-sync.shregenerates golden snapshots after version bump, but.githooks/pre-commitonly staged 5 managed files —tests/golden-snapshots.jsonwas left unstaged. This caused recurring CI failures on every version bump.Additionally, the regeneration logic was duplicated: 48 lines of inline Python in
release-sync.sh+ a separate check inrelease-preflight.sh.Changes
scripts/regenerate-golden-snapshots.py— single source of truth for snapshot regenerationrelease-preflight.sh: auto-regenerate stale snapshots during pre-commit (instead of just failing)release-sync.sh: replace 48-line inline Python with single script call.githooks/pre-commit: addtests/golden-snapshots.jsonto staged file listtests/test_release_hooks.py: add new script to test fixtureNet: -50 lines inline Python, +1 reusable script (85 lines with docstrings), deduplication complete.