Skip to content

One manager to rule them all#7

Open
DavisPoGo wants to merge 5 commits intoevilmoses:devfrom
DavisPoGo:OneManager
Open

One manager to rule them all#7
DavisPoGo wants to merge 5 commits intoevilmoses:devfrom
DavisPoGo:OneManager

Conversation

@DavisPoGo
Copy link

@DavisPoGo DavisPoGo commented Jan 29, 2018

Description

This PA modification allows you to run all your alerts with 1 manager. It accomplishes this by three main additions

  1. All the filters get checked. For each filter that is matched, an alarm is triggered
  2. All matching geofence(s) for each event can trigger an alarm. (you do not need a duplicated filter set for each geofence)
  3. A new file, channel_id.json, is required. This file translates your geofence+filter combination into the channel/webhook portion of the discord webhook url
    Also gkey iteration is used for multiple gkey api support

See update at the beginning of README for more indepth description

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (would cause existing functionality to change)

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Wiki Update

  • This change requires an update to the Wiki.
  • This change does not require an update to the Wiki.

Checklist

  • This change follows the code style of this project.
  • This change only changes what is necessary to the feature.

@bbdoc
Copy link

bbdoc commented Mar 5, 2018

Are you still working on this one ? I would really love being able to define multiple custom_dts in channel_id.json instead of only webhook_url so I could tackle both discord and Telegram, but also define multiple discord channels (e.g. one for gyms one for monsters).

@evilmoses
Copy link
Owner

@bbdoc, I'm not sure this is really needed having actually started using rules properly.

I had 30 odd managers and now have 1 manager, so it is possible to get to 1 manager without this PR. I mean, my filter file is now 3000 lines long, but it runs like a dream lol

@bbdoc
Copy link

bbdoc commented Mar 6, 2018

Yep, I'm looking at also doing something like that, but would be so much easier to be able to set up a separate file linking geofences with discord/telegram channels.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants