Conversation
✅ Deploy Preview for mistql canceled.
|
There was a problem hiding this comment.
Pull Request Overview
This PR adds LRU caching functionality to the MistQL parser in Python to improve performance for repeated queries. The cache stores parsed ASTs for queries to avoid re-parsing the same query string multiple times.
- Added
parse_lru_cache_sizeparameter toMistQLInstanceconstructor with default size of 1 - Replaced direct
parse()calls with cached version usingfunctools.lru_cache - Added comprehensive test suite covering basic functionality, size limits, performance, statistics, and edge cases
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| py/mistql/instance.py | Added LRU cache integration with configurable cache size and cached parse method |
| py/tests/test_lru_cache.py | Comprehensive test suite for LRU cache functionality including performance, statistics, and edge cases |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
793c8c5 to
0074858
Compare
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
0074858 to
83a6f24
Compare
Owner
Author
|
Gonna go ahead and merge this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From the discord