Conversation
✅ Deploy Preview for mistql canceled.
|
evinism
force-pushed
the
evin/more_shared_tests
branch
from
6dc0aea to
ad2524b
Compare
Owner
Author
|
I think it makes sense to merge this and fix up the JS implementation of MistQL for the 0.5.0 release, a la #207. Just having this in a PR isn't that helpful to me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This gives us a hint more behavioral coverage. #204 came out of this, too, so these are clearly edge cases we care about.
Lots of failing tests now, too.