Skip to content

test coverage, profiling tests, and rearranging uv lock#206

Merged
evinism merged 2 commits intomainfrom
evin/perf_stats_dev_deps_coverage
Sep 24, 2025
Merged

test coverage, profiling tests, and rearranging uv lock#206
evinism merged 2 commits intomainfrom
evin/perf_stats_dev_deps_coverage

Conversation

@evinism
Copy link
Copy Markdown
Owner

@evinism evinism commented Sep 24, 2025

No description provided.

@netlify
Copy link
Copy Markdown

netlify Bot commented Sep 24, 2025

Deploy Preview for mistql canceled.

Name Link
🔨 Latest commit 13a5e4d
🔍 Latest deploy log https://app.netlify.com/projects/mistql/deploys/68d47d7d72291600098525f1

@evinism evinism requested a review from Copilot September 24, 2025 23:07
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances the test infrastructure by adding code coverage reporting and improving profiling output in tests. The changes configure pytest with coverage reporting and update the profiling test to output more useful statistics while saving profile data for analysis.

  • Adds pytest-cov dependency and enables coverage reporting in CI
  • Updates profiling test to output top 20 functions and save profile stats
  • Migrates from optional-dependencies to dependency-groups in pyproject.toml

Reviewed Changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.

File Description
py/tests/test_performance.py Improves profiling output by removing string buffer and showing top 20 stats
py/pyproject.toml Adds pytest-cov dependency and migrates to dependency-groups format
.github/workflows/python.yml Enables pytest coverage reporting and adds PROFILE environment variable

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread .github/workflows/python.yml Outdated
@@ -35,7 +36,7 @@ jobs:
- name: Install deps
run: uv pip install -e ".[dev]"
Copy link

Copilot AI Sep 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The installation command still references the old [dev] optional dependency format, but pyproject.toml has been updated to use dependency-groups. This should be changed to uv pip install -e . --group dev to match the new dependency-groups format.

Suggested change
run: uv pip install -e ".[dev]"
run: uv pip install -e . --group dev

Copilot uses AI. Check for mistakes.
@evinism evinism merged commit 57315e7 into main Sep 24, 2025
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants