Unify session model (closes KI-2, KI-5)#3
Merged
Merged
Conversation
…vidence fields Single source of truth for session-related models is now scan_session.py: - Severity enum moved here from session.py - Finding dataclass moved here, gained fields: * target: which host/URL/contract the finding pertains to * evidence: list of artifacts (nmap xml, HTTP responses, etc.) * cve_ids: list form, kept in sync with legacy single 'cve' field - ScanSession gained findings list + add_finding() method - summary() now reports severity_breakdown like PentestSession.summary() did Fixes KI-5: agents (ReconAgent in particular) were already constructing Finding(target=..., evidence=[...]) which raised TypeError because those fields did not exist on the dataclass. They exist now. session.py (legacy) will become a re-export shim in the next commit, keeping all current import sites working without code changes. Refs: STANDOFF.md day 3/30, closes KI-5 (partial: KI-2 in commit 2)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.