Day 5: Orchestrator v2 — config-driven pipeline (closes KI-1)#5
Merged
Conversation
Day 5, part of KI-1 fix. Orchestrator.__init__ now takes (config, phases, dry_run) instead of (phases, authorized_scope, dry_run). authorized_scope moved to run() since scope is per-target, not per-orchestrator. - builds a shared LLMClient lazily (skipped entirely in dry-run, so no API key is ever needed for a dry run) - builds an AuditLogger per session - constructs every agent with the new BaseAgent contract: Agent(config, session, llm, audit) - _dispatch refactored to a dict lookup test_orchestrator.py: test_dry_run_authorized_scope updated to pass authorized_scope via run() — the other 10 tests are unchanged. Refs: STANDOFF.md day 5/30
The CLI was calling Orchestrator(config) and orchestrator.run_pipeline( session) — neither existed. It also created a PentestSession that the orchestrator silently ignored. Now: - Orchestrator(config=config, dry_run=dry_run) - session = orchestrator.run(target, authorized_scope=...) - the orchestrator owns session creation (single source of truth) New options: - --dry-run : run the full pipeline with no real network calls - --scope : repeatable authorized-scope entry (--scope a --scope b) - --provider now overrides config only when given (was hardcoded openai) Verified: 'python -m cyberai scan 127.0.0.1 --dry-run' runs all four phases and exits cleanly — the exact invocation that crashed before. Refs: STANDOFF.md day 5/30, closes KI-1
docs: mark KI-1 as fixed (7/8 closed)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.