Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I love the idea of this project, but as we use gitlab at work, I figured I'd add support for that.
Also fixed a bug where it wouldn't fetch the previous directories/categories if the branch wasn't named
master.Architectural changes
Providerinterface to allow implementing any provider-providercommand-line arg, defaulting togithubProviderinterfacetreeand committing that. Instead, it is done in one action in the same way as for the immediate commitproviderandgitas appropriate (and to avoid import loops)Breaking changes
usage
github-tokentoprovider-tokencode
gitpackageTests
What tests? There were no tests to begin with, and I'm no overachiever!
I've manually tested this on both Gitlab and Github, for both PR mode and immediate commit:
https://gitlab.com/phroggyy/decision-log/-/merge_requests/1
phroggyy/decision-log-test#1