demo: rebuild the workspace lib before build and dev#19
Merged
Conversation
Stale eksml/dist builds have twice produced misleading local benchmark comparisons. The demo's build, dev, and start scripts now rebuild @eksml/xml first (~700ms) so local runs always reflect current source.
The demo's build script now builds the library itself.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stale
eksml/distbuilds have twice produced misleading local benchmark comparisons (an April-old dist during the easysax investigation, and the recent local-vs-deployed 8% confusion). The demo consumes@eksml/xmlthroughdist/, so a stale build silently benchmarks old code.build,dev, andstartnow runpnpm --filter @eksml/xml buildfirst (~700ms). Explicit chaining instead ofprebuildlifecycle hooks so behavior doesn't depend on pnpm'senable-pre-post-scriptssetting.Notes:
devrebuilds once at startup — live lib changes during a dev session still need a manual rebuild (or a future watch task).Verified:
demo pnpm buildregenerateseksml/distbefore bundling, 7 SSG pages build cleanly.