Two impovents and one bug fix #1488
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e gruped by time to make it look cleaner. 2:) On top of the standings screen there will be a disclaimer that all unplyed matches are counted as drwas.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1488 +/- ##
=======================================
Coverage 94.94% 94.94%
=======================================
Files 120 120
Lines 4350 4350
=======================================
Hits 4130 4130
Misses 220 220 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
evroon
reviewed
Dec 23, 2025
|
|
||
| export function compareDateTime(datetime1: string, datetime2: string) { | ||
| return parseISO(datetime1) > parseISO(datetime2); | ||
| return parseISO(datetime1).getTime() - parseISO(datetime2).getTime(); |
Owner
There was a problem hiding this comment.
Suggested change
| return parseISO(datetime1).getTime() - parseISO(datetime2).getTime(); | |
| return dayjs(datetime1) - dayjs(datetime2); |
I try to use dayjs now everywhere since that's also what mantine uses
evroon
reviewed
Dec 23, 2025
Owner
There was a problem hiding this comment.
Thanks, I have two suggestions
Also, CI fails on typing errors: https://github.com/evroon/bracket/actions/runs/20457073860/job/58811681300?pr=1488
| values.players_can_be_in_multiple_teams, | ||
| values.auto_assign_courts, | ||
| values.start_time.toISOString(), | ||
| new Date(values.start_time).toISOString(), |
Owner
There was a problem hiding this comment.
this already works right?
If not, it should just be:
Suggested change
| new Date(values.start_time).toISOString(), | |
| values.start_time, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed Docker compose for new postgress version from #1389
Did my own quick fix against irritation. Is see something simmilar was done in #1267 please use #1267
And added sorting for the dashboard to look cleaner.