Pin GitHub Actions to SHAs and fix zizmor findings#10
Merged
Conversation
Pin every third-party action in .github/workflows to a commit SHA (with a readable version comment) and resolve the zizmor audit findings that surfaced once the workflows were no longer protected by tag mutability: - artipacked: set persist-credentials: false on every actions/checkout - excessive-permissions: add top-level "permissions: contents: read" to ci.yml and publish.yml; docs.yml already declares its own block - unpinned-uses: pin pypa/gh-action-pypi-publish to v1.14.0 by SHA instead of the moving release/v1 branch zizmor . now reports no findings. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.github/workflows/to a commit SHA (with a readable# vX.Y.Zcomment) vianpx actions-up --style shazizmor .:persist-credentials: falseon everyactions/checkoutpermissions: contents: readtoci.ymlandpublish.yml(docs.ymlalready declared its own)pypa/gh-action-pypi-publishtov1.14.0by SHA instead of the movingrelease/v1branchzizmor .now reports No findings to report. Good job! (11 suppressed).Test plan
npx actions-up --style sha --yesapplied 19 SHA updateszizmor .exits 0 with no findingsprek run --files .github/workflows/*.ymlpasses prettier formatting🤖 Generated with Claude Code