Open
Conversation
Contributor
|
If this doesn't get merged feel free to use the maintained fork. https://github.com/asilvas/faiss-node/blob/main/README.md?plain=1#L94-L96 |
Author
Thank you, i will |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds a new
reconstructmethod to the FAISS index classes, allowing users to retrieve the original vector for a given index key. It also exposes this method to the JavaScript API and provides tests to verify its correctness and error handling.New API feature: Vector reconstruction
Added a
reconstructmethod to the base classIndexBase, enabling retrieval of the stored vector at a specified key, with validation and error handling. (src/faiss.cc)Exposed the
reconstructmethod as an instance method on theIndex,IndexFlatL2, andIndexFlatIPclasses, making it available in the JavaScript API. (src/faiss.cc) [1] [2] [3]Testing
reconstruct.test.jsto verify correct reconstruction of vectors, handling of invalid keys, and compatibility with bothIndexFlatL2andIndexclasses. (test/reconstruct.test.js)