Several improvements to bash indentation script + Tests integrated via travis#6
Open
shri314 wants to merge 37 commits intoewiger:masterfrom
Open
Several improvements to bash indentation script + Tests integrated via travis#6shri314 wants to merge 37 commits intoewiger:masterfrom
shri314 wants to merge 37 commits intoewiger:masterfrom
Conversation
...
if [ $? == 0 ]
then
cat <<EOM
abc
EOMFAKE
EOM
EOM
fi
...
will be indented as
...
if [ $? == 0 ]
then
cat <<EOM
abc
EOMFAKE
EOM
EOM
fi
...
- Restructured the if conditions using "continue" instead of complex if-else ladder - (at the risk of a few unknown regressions)
- Remove in_here_doc flag, instead directly depend on here_string
- Remove in_ext_quote flag, instead directly depend on ext_quote_string
- Removed defer_ext_quote flag
Now:
func() {
Y1="This----------
this is <<HERE--
qu\"otes"---
echo------
}
Indents as:
func() {
Y1="This----------
this is <<HERE--
qu\"otes"
echo
}
The following:
func() {
echo alpha \
beta \
gamma \
delata
echo
echo a |
grep x |
grep y |
grep p
echo
echo a &&
grep x &&
grep y &&
grep p
echo
echo a ||
grep x ||
grep y ||
grep p
echo
}
Will indent as below:
func() {
echo alpha \
beta \
gamma \
delata
echo
echo a |
grep x |
grep y |
grep p
echo
echo a &&
grep x &&
grep y &&
grep p
echo
echo a ||
grep x ||
grep y ||
grep p
echo
}
shri314
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://travis-ci.org/shri314/beautify_bash/jobs/252237202.
Additional contributions from cheako/beautify_bash