You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Thank you for your efforts @PhilippSPOTTERON !
Let us point a few things.
As we stated before, this fork is only an intermediate one between J4 compatibility and the official K2 version.
Theoretically it should lose its purpose when K2 official version supporting J4 sees the light.
This is still K2, and does not only support J4, but also J3.9+.
Labeling the J4 support somehow can be a good idea, minor displacement of K2 text and the icon part of the logo can also be another.
But changing the K2 logo itself is not! because this is still K2, beside if it wasn't, if the name still K2 regardless of the fact that the component was changed, K2 summit has not been changed :) (we can change the component but we cannot change the summit, it won't K2 then and won't be majestic and the hardest to climb)
We think small adjustment to just label the version differently for users should be enough (ex: what you did with the label k2 for j4, except it should be maybe k2 for J3.9+)
If you have different opinion, please share it in here.
And again thank you for efforts, it is much appreciated!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Logo Upgrades