feat(cleanup): add progress logging for manifest reads and delete phase#5
Merged
Merged
Conversation
Adds three types of progress logging to cleanup operations: 1. Manifest read progress: logs every ~5% of manifests processed (e.g. 'Manifest progress: 500/9703 (5.2%)') 2. Inspection summary: after manifest processing, logs counts of old manifests and referenced files by type 3. Delete progress: logs every 1000 files submitted for deletion, plus a completion summary with total count Co-Authored-By: Jan van der Vegt <jan@exa.ai>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
|
ACTION NEEDED The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification. For details on the error please inspect the "PR Title Check" action. |
dpruijt
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds progress logging to the cleanup operation so operators can monitor long-running cleanup jobs instead of waiting blindly for hours.
Three new log points:
Manifest read progress — logs every ~5% of manifests processed:
Inspection summary — after manifest processing, logs what was found:
Delete progress — logs every 1000 files submitted for deletion, plus completion:
All logging uses
info!level — visible with default RUST_LOG settings.Review & Testing Checklist for Human
max(total/20, 100)manifests)Notes
AtomicU64for lock-free progress counting across concurrent manifest readsmax(total/20, 100)— for 9703 manifests this logs ~20 times during the read phaseLink to Devin session: https://app.devin.ai/sessions/bb810ab5769542e0a12b08c2505d2ae1
Requested by: @jan-exa