Skip to content

feat(cleanup): add progress logging for manifest reads and delete phase#5

Merged
dpruijt merged 1 commit into
mainfrom
devin/1779898094-progress-logging
May 27, 2026
Merged

feat(cleanup): add progress logging for manifest reads and delete phase#5
dpruijt merged 1 commit into
mainfrom
devin/1779898094-progress-logging

Conversation

@jan-exa

@jan-exa jan-exa commented May 27, 2026

Copy link
Copy Markdown

Summary

Adds progress logging to the cleanup operation so operators can monitor long-running cleanup jobs instead of waiting blindly for hours.

Three new log points:

  1. Manifest read progress — logs every ~5% of manifests processed:

    [INFO] Manifest progress: 500/9703 (5.2%)
    [INFO] Manifest progress: 1000/9703 (10.3%)
    ...
    [INFO] Successfully processed all 9703 manifests
    
  2. Inspection summary — after manifest processing, logs what was found:

    [INFO] Inspection summary: 7926 old manifests, 9706 referenced data files,
           75045 referenced deletion files, 0 referenced tx files, 0 referenced indices
    
  3. Delete progress — logs every 1000 files submitted for deletion, plus completion:

    [INFO] Delete progress: 1000 files submitted
    [INFO] Delete progress: 2000 files submitted
    ...
    [INFO] Delete phase complete: 35288 files deleted (7926 old manifests)
    

All logging uses info! level — visible with default RUST_LOG settings.

Review & Testing Checklist for Human

  • Verify log interval makes sense for your dataset size (logs every max(total/20, 100) manifests)
  • After merge, rebuild the pylance wheel and upload to S3 for the Databricks cleanup job

Notes

  • No functional changes — only adds logging
  • Uses AtomicU64 for lock-free progress counting across concurrent manifest reads
  • The log interval for manifests is max(total/20, 100) — for 9703 manifests this logs ~20 times during the read phase

Link to Devin session: https://app.devin.ai/sessions/bb810ab5769542e0a12b08c2505d2ae1
Requested by: @jan-exa

Adds three types of progress logging to cleanup operations:

1. Manifest read progress: logs every ~5% of manifests processed
   (e.g. 'Manifest progress: 500/9703 (5.2%)')

2. Inspection summary: after manifest processing, logs counts of
   old manifests and referenced files by type

3. Delete progress: logs every 1000 files submitted for deletion,
   plus a completion summary with total count

Co-Authored-By: Jan van der Vegt <jan@exa.ai>
@devin-ai-integration

Copy link
Copy Markdown

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@github-actions

Copy link
Copy Markdown

ACTION NEEDED
Lance follows the Conventional Commits specification for release automation.

The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification.

For details on the error please inspect the "PR Title Check" action.

@devin-ai-integration devin-ai-integration Bot changed the title [cleanup]: add progress logging for manifest reads and delete phase feat(cleanup): add progress logging for manifest reads and delete phase May 27, 2026
@github-actions github-actions Bot added the enhancement New feature or request label May 27, 2026
@dpruijt
dpruijt merged commit 0fdab58 into main May 27, 2026
10 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants