-
Notifications
You must be signed in to change notification settings - Fork 4
💄 app: improve freeze card ui #995
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
dieguezguille
wants to merge
6
commits into
main
Choose a base branch
from
freeze
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
be23487
💄 app: drop unfreeze card label
dieguezguille c396d06
✨ app: add card freeze confirmation sheet
dieguezguille 0cadada
✨ app: show frozen overlay on card
dieguezguille c6c8d3a
✨ app: add freeze controls to home card
dieguezguille 080a61b
✨ app: create shared switch component
dieguezguille 7082d26
💄 app: add haptic feedback to card actions
dieguezguille File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "@exactly/mobile": patch | ||
| --- | ||
|
|
||
| 💄 drop unfreeze card label |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "@exactly/mobile": patch | ||
| --- | ||
|
|
||
| ✨ add card freeze confirmation sheet |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "@exactly/mobile": patch | ||
| --- | ||
|
|
||
| ✨ show frozen overlay on card |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "@exactly/mobile": patch | ||
| --- | ||
|
|
||
| ✨ add freeze controls to home card |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "@exactly/mobile": patch | ||
| --- | ||
|
|
||
| ✨ create shared switch component |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "@exactly/mobile": patch | ||
| --- | ||
|
|
||
| 💄 add haptic feedback to card actions |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,55 @@ | ||
| import React from "react"; | ||
| import { useTranslation } from "react-i18next"; | ||
| import { Pressable } from "react-native"; | ||
|
|
||
| import { Snowflake } from "@tamagui/lucide-icons"; | ||
| import { YStack } from "tamagui"; | ||
|
|
||
| import ModalSheet from "../shared/ModalSheet"; | ||
| import Button from "../shared/StyledButton"; | ||
| import Text from "../shared/Text"; | ||
|
|
||
| export default function CardFreezeSheet({ | ||
| onClose, | ||
| onConfirm, | ||
| open, | ||
| }: { | ||
| onClose: () => void; | ||
| onConfirm: () => void; | ||
| open: boolean; | ||
| }) { | ||
| const { t } = useTranslation(); | ||
| return ( | ||
| <ModalSheet open={open} onClose={onClose}> | ||
| <YStack | ||
| gap="$s7" | ||
| borderTopLeftRadius="$r5" | ||
| borderTopRightRadius="$r5" | ||
| backgroundColor="$backgroundSoft" | ||
| $platform-android={{ paddingBottom: "$s5" }} | ||
| > | ||
| <YStack gap="$s4" paddingTop="$s5" paddingHorizontal="$s5"> | ||
| <Text emphasized headline> | ||
| {t("Freeze your card?")} | ||
| </Text> | ||
| <Text subHeadline secondary> | ||
| {t("Your card will be temporarily paused. You can unfreeze it anytime.")} | ||
| </Text> | ||
| </YStack> | ||
| <YStack gap="$s4" paddingHorizontal="$s4" paddingBottom="$s7"> | ||
| <Button primary onPress={onConfirm}> | ||
| <Button.Text>{t("Freeze card")}</Button.Text> | ||
| <Button.Icon> | ||
| <Snowflake strokeWidth={2.5} /> | ||
| </Button.Icon> | ||
| </Button> | ||
| <Pressable onPress={onClose}> | ||
| <Text emphasized footnote color="$interactiveBaseBrandDefault" alignSelf="center"> | ||
| {t("Cancel")} | ||
| </Text> | ||
| </Pressable> | ||
| </YStack> | ||
| </YStack> | ||
| </ModalSheet> | ||
| ); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make freeze/unfreeze assertions deterministic to avoid false positives.
tapOn: Freeze cardis reused for both the sheet CTA and the card row, and the second tap can be ignored ifisSettingCardStatusis still true (src/components/card/Card.tsx, onPress guard). This can pass the flow without actually validating unfreeze.Proposed flow hardening
📝 Committable suggestion