Skip to content

🔧 finance: update cbXRP max supply #802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cruzdanilo merged 1 commit into from
Apr 27, 2026
Merged

🔧 finance: update cbXRP max supply #802

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion hardhat.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -396,7 +396,7 @@ const hardhatConfig: Config = {
cbXRP: {
networks: ["base", "base-sepolia"],
adjustFactor: 0.6,
maxSupply: 420_000,
maxSupply: 1_100_000,
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot Apr 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick | 🔵 Trivial

LGTM! Parameter increase is technically correct.

The maxSupply increase from 420_000 to 1_100_000 is syntactically valid and properly formatted. The change relaxes the supply cap enforced in Market.sol:afterDeposit, allowing more shares to be minted for the cbXRP market.

Optional: Given the ~162% increase in supply cap, you may want to ensure this change is coordinated with:

  • Risk management parameters and exposure limits
  • Liquidity analysis for the cbXRP market
  • Any related collateral or utilization monitoring

interestRateModel: {
minRate: 1.5e-2,
naturalRate: 2e-1,
Expand Down
Loading