Draft
Conversation
ArBridgeman
commented
Feb 13, 2026
| from exasol.toolbox.util.workflows.render_yaml import YamlRenderer | ||
|
|
||
|
|
||
| class InvalidWorkflowPatcherYamlError(Exception): |
Collaborator
Author
There was a problem hiding this comment.
- Check initial design with @tkilias , likely in a call
- Add structlog - bound logging so clear what's happening where as many sub-processes & multiple files
- Fix identical class names
WorkflowPatcher-> original actually has a many:1 relationship and new one has a 1:1. Other naming ideas there? Or other way to think of the class? - Create follow up PR to iterate over the workflows
- Add more test cases to the new
WorkflowPatcherand to theTemplateRenderer-> multi additions, etc. - Fix lint-importer
- Simplify workflow callers -> we have the class Workflows -> maybe that should just be a function to iterate over all of the inputs from tbx with yield to output a specific one or something?
- Likely break into 1-3 smaller PRs for reviewers
Collaborator
Author
There was a problem hiding this comment.
Semi-common use cases not covered:
- Skipping syncing certain workflows
-> we could add to theWorkflowPatcherconfig a field with a list of workflow names to skip
-> at some point for that field & workflow name, i would want to add a literal check for comparing to the active ones - adding / modifying jobs
-> this one is tricky as we want the users to mostly put new jobs into their own workflows. however, would we want them to be able to add to the merge-gate like so:
https://github.com/exasol/python-toolbox/blob/main/.github/workflows/merge-gate.yml#L35
?
-> when removing jobs, we don't remove them fromneedsyet - modifying a matrix for a job, like
https://github.com/exasol/python-toolbox/blob/main/.github/workflows/slow-checks.yml#L24
-> we could change the pattern here some like creating a workflow to get out specific PROJECT_CONFIG values & returning them in a matrix. For the standard-slow tests, we could change it to get a configurable target -- just need to figure out a way to do the names...maybe there's a trip with github's json, idk
-> maybe other / simpler ideas for that too
-> could alternately handle if they could modify a job
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
relates to #698
Checklist
Note: If any of the items in the checklist are not relevant to your PR, just check the box.
For any Pull Request
Is the following correct:
When Changes Were Made
Did you:
When Preparing a Release
Have you: