Skip to content

[.github/workflows] add basic tests workflow#11

Merged
pabloyoyoista merged 1 commit intomasterfrom
combine-ci
Oct 2, 2025
Merged

[.github/workflows] add basic tests workflow#11
pabloyoyoista merged 1 commit intomasterfrom
combine-ci

Conversation

@pabloyoyoista
Copy link
Copy Markdown
Collaborator

@pabloyoyoista pabloyoyoista commented Jul 5, 2024

Fixes #6

@pabloyoyoista pabloyoyoista force-pushed the combine-ci branch 19 times, most recently from d7dcc8c to baed7a4 Compare July 9, 2024 08:29
@pabloyoyoista
Copy link
Copy Markdown
Collaborator Author

Actually, seems like adding these tests already identified a bug? The tests are failing consistently across all versions and I can reproduce locally. So unless there's a dependency I'm missing, it seems quite likely to be a problem

@pabloyoyoista
Copy link
Copy Markdown
Collaborator Author

Of course, you already knew that. What it needs is the two commits from Carl's branch 'tagel'. Would be pretty useful to incorporate those into 'master'

@pabloyoyoista pabloyoyoista marked this pull request as ready for review July 9, 2024 08:41
@berkeman
Copy link
Copy Markdown
Member

Is this failing due to bugs that have been fixed recently in the main branch?

@pabloyoyoista pabloyoyoista force-pushed the combine-ci branch 7 times, most recently from 40da385 to 2a085fa Compare July 22, 2025 14:42
@pabloyoyoista pabloyoyoista force-pushed the combine-ci branch 2 times, most recently from 63dd4ad to aa0e70c Compare July 22, 2025 14:49
@pabloyoyoista
Copy link
Copy Markdown
Collaborator Author

Is this failing due to bugs that have been fixed recently in the main branch?

Yes, and those fixes are now incorporated. This runs successfully now!

@pabloyoyoista pabloyoyoista force-pushed the combine-ci branch 2 times, most recently from 8412ec7 to 8559353 Compare July 29, 2025 10:36
@pabloyoyoista pabloyoyoista merged commit c23c295 into master Oct 2, 2025
4 checks passed
@pabloyoyoista pabloyoyoista deleted the combine-ci branch October 2, 2025 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add CI to build and run tests

2 participants