New client api performGenericRequest allows for custom graphql errors#5
Open
Matt-st wants to merge 4 commits intoexcitement-engineer:masterfrom
Open
New client api performGenericRequest allows for custom graphql errors#5Matt-st wants to merge 4 commits intoexcitement-engineer:masterfrom
Matt-st wants to merge 4 commits intoexcitement-engineer:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The GraphQL specification has gone through changes with regards to the error specification seen here. The specification refers to preferred and non preferred ways of representing errors. In the most recent specification update from 2018, extensions are used to hold extra information that organizations may need to make their error handling more robust. Many organizations have used GraphQL prior to the addition of extensions in 2018 and therefore have created custom Error objects for their GraphQL schema implementations. To make this graphql client more robust and gain the ability to handle GraphQL errors that don't follow the current specification I thought I would add a
performGenericRequestthat can handle custom error objects. Please review and share your thoughts.