Skip to content

Feature: Pause Points#62

Open
dunronet wants to merge 3 commits intoexeldro:masterfrom
dunronet:pause_points
Open

Feature: Pause Points#62
dunronet wants to merge 3 commits intoexeldro:masterfrom
dunronet:pause_points

Conversation

@dunronet
Copy link
Copy Markdown
Contributor

Changes to permit the addition of "pauses" on a given DSK.

A pause does the same thing as deselecting a dsk item (e.g. Hide Transition), The added benefit is you can place the pause anywhere in your item list, and you can have multiple pauses.

  • Addition of UI button to Add a Pause, as well as corresponding websocket vendor
    • Change existing Pause UI to from a Pause button to a Stop button.
  • Addition of websocket vendor and supporting backend to remove all scenes from a DSK (which currently removes all items) while keeping all other settings for the DSK intact.

Limitations:

  • Pauses currently leverage the fact that no scene exists with the given name. Future effort would be needed to properly differentiate between scenes and pauses, Similarly, there is no distinguishing between Pauses and Scenes in the UI.

…o include vendor function to remove all scenes
}
void DownstreamKeyer::on_actionAddPausePoint_triggered() {
// add a message box in...
std::string pause_name = "Give pause a unique name";
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not translatable at the moment, use obs_module_text

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for that call out.

I also realized I probably wasn't using obs_module_text correctly elsewhere so I've fixed that too.

I've updated the en-US locale file to use Add="Add Scene" and AddPause="Add Pause"

this will avoid breaking "Add" for existing languages. (I don't trust my grammar to try to update the existing translations)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants