Conversation
fix: Typo in the var name and wrong addition result
|
Hello. Thanks for opening a PR on Exercism 🙂 We ask that all changes to Exercism are discussed on our Community Forum before being opened on GitHub. To enforce this, we automatically close all PRs that are submitted. That doesn't mean your PR is rejected but that we want the initial discussion about it to happen on our forum where a wide range of key contributors across the Exercism ecosystem can weigh in. You can use this link to copy this into a new topic on the forum. If we decide the PR is appropriate, we'll reopen it and continue with it, so please don't delete your local branch. If you're interested in learning more about this auto-responder, please read this blog post. Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it. |
|
Hello 👋 Thanks for your PR. This repo does not currently have dedicated maintainers. Our cross-track maintainers team will attempt to review and merge your PR, but it will likely take longer for your PR to be reviewed. If you enjoy contributing to Exercism and have a track-record of doing so successfully, you might like to become an Exercism maintainer for this track. Please feel free to ask any questions, or chat to us about anything to do with this PR or the reviewing process on the Exercism forum. (cc @exercism/cross-track-maintainers) |
| updateScore(&highscores, "Freyja Ćirić", 73) | ||
| // Returns ["Dave Thomas": 0, "José Valim": 486_373, "Freyja Ćirić": 73] | ||
| updateScore(&highScores, "Freyja Ćirić", 73) | ||
| // Returns ["Dave Thomas": 0, "José Valim": 486_373, "Freyja Ćirić": 12_771_081] |
There was a problem hiding this comment.
So the type on the line above is valid. But it should return the updated score, not the initial score
2 participants
fix: Typo in the var name and wrong addition result