renamed text parser package to cql2text#3
Merged
Merged
Conversation
exergy-dev
added a commit
that referenced
this pull request
May 4, 2026
#2 — JSON op names are looked up case-insensitively against the Operator enum. Replaced the strict-membership knownOps set with a canonicalOps map keyed on the lowercased form, yielding the canonical Operator constant. Crucially, OpIsNull's canonical value is camelCase ('isNull'), so the lookup must yield the canonical form, not the lowercased input — encoders need the canonical to emit correctly. Regression test (TestParseOpCanonicalCasePreserved) pins this for the four input casings. #3 — Unknown JSON op strings fall back to *FunctionCall{Name, Args} instead of erroring. Args structure is still validated (must be a JSON array). Function names are case-preserved (only operator names are case-insensitive). #4 (JSON side) — interval endpoints may be {"property":"<name>"} objects, parsed into *PropertyRef and routed through the IntervalLit endpoint slot (now possible after step 0's AST contract change). Encoder emits property endpoints as their JSON object form. Mixed literal/ property/unbounded combinations round-trip byte-equal.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.