Skip to content

fix zkillboard socket url#999

Open
esunder wants to merge 2 commits intoexodus4d:masterfrom
esunder:master
Open

fix zkillboard socket url#999
esunder wants to merge 2 commits intoexodus4d:masterfrom
esunder:master

Conversation

@esunder
Copy link
Copy Markdown

@esunder esunder commented Oct 2, 2020

#995 updating zkillboard socket url

static initWebSocket(){
if(!SystemKillboardModule.ws){
SystemKillboardModule.ws = new WebSocket('wss://zkillboard.com:2096');
SystemKillboardModule.ws = new WebSocket('wss://zkillboard.com/websocket');
Copy link
Copy Markdown

@gparent gparent Oct 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if you had this working on your instance but the correct URL seems to be wss://zkillboard.com/websocket/ otherwise you get a permanent redirect and the UI shows as Offline (Red dot).

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, yes you are correct, it requires the trailing slash, works fine in our instance as wss://killboard.com/websocket/

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't you need the "z" in zkillboard? I am still getting my apache server running, so I shamefully, did not get to test.

But when I test a websocket connection on the command line with NodeJS, I need to use: wss://zkillboard.com/websocket/

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added the trailing slash though. Thank you guys for catching!

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, i just copy/pasted from gparent's comment. Full line in my working fork is:

SystemKillboardModule.ws = new WebSocket('wss://zkillboard.com/websocket/');

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I edited my comment. On my fork I have the working link and rebuilt the static files.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good. Thanks guys!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants