Restore --networking flag on conversation create/update - #99
Open
timanglade wants to merge 1 commit into
Open
Conversation
The --networking flag was accidentally dropped from conversation-level CLI commands when sandbox settings were refactored into ConversationSandboxRuntimeArgs (commit 3f206d6, PR exoharness#25). The flag remained on agent create/update, and the underlying enable_networking field stayed in the exoharness API, but conversation create/update lost their CLI surface for controlling it. This restores --networking on both conversation create and conversation update by: - Adding networking to ConversationSandboxRuntimeArgs - Adding --clear-networking to ConversationSandboxRuntimeUpdateArgs - Adding enable_networking: Option<bool> to ConversationConfig and CreateConversationRequest - Wiring the conversation-level override through conversation_sandbox and harness_tool so it falls back to the agent default when unset Also updates agent-harness-e2e.ts to pass --networking at conversation create time (instead of a separate conversation update call) so the sandbox is created with the correct networking policy from the start. Finally, injects provider-specific API key env vars (e.g. FIREWORKS_API_KEY) into the opencode sandbox env alongside OPENCODE_API_KEY, so the opencode server can resolve non-default providers.
akrentsel
force-pushed
the
add-opencode-harness
branch
2 times, most recently
from
July 1, 2026 23:23
39faf3e to
8d412db
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The --networking flag was accidentally dropped from conversation-level CLI commands when sandbox settings were refactored into ConversationSandboxRuntimeArgs (commit 3f206d6, PR #25). The flag remained on agent create/update, and the underlying enable_networking field stayed in the exoharness API, but conversation create/update lost their CLI surface for controlling it.
This restores --networking on both conversation create and conversation update by:
Also updates agent-harness-e2e.ts to pass --networking at conversation create time (instead of a separate conversation update call) so the sandbox is created with the correct networking policy from the start.
Finally, injects provider-specific API key env vars (e.g. FIREWORKS_API_KEY) into the opencode sandbox env alongside OPENCODE_API_KEY, so the opencode server can resolve non-default providers.