Conversation
kobajagi
reviewed
Jan 26, 2026
kobajagi
reviewed
Jan 26, 2026
sauterp
approved these changes
Jan 26, 2026
Member
sauterp
left a comment
There was a problem hiding this comment.
the code looks correct, just to be sure I would recommend doing a quick test before merging, that updates some other field of an instance unrelated to this change to verify that when you don't set the --application-consistent-snapshot that the state of this feature isn't touched. (I guess I would do two tests, one where it's true and one where it's false)
kobajagi
reviewed
Jan 26, 2026
Member
Author
thx @sauterp , I've updated the description with the tests |
kobajagi
approved these changes
Jan 26, 2026
sauterp
approved these changes
Jan 30, 2026
c1e25e5 to
2c8ed9f
Compare
Contributor
|
@tdantas add a line in CHANGELOG.md and you can merge it. |
bf4f9bf to
5a68770
Compare
kobajagi
approved these changes
Feb 2, 2026
sauterp
approved these changes
Feb 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
INSTANCE
TEMPLATES
SNAPSHOTS
Checklist
(For exoscale contributors)
Testing