feat: add runtime and init-image support (TDD)#3
Draft
explicitcontextualunderstanding wants to merge 19 commits intomainfrom
Draft
feat: add runtime and init-image support (TDD)#3explicitcontextualunderstanding wants to merge 19 commits intomainfrom
explicitcontextualunderstanding wants to merge 19 commits intomainfrom
Conversation
The entrypoint override was being appended after the image name, causing it to be treated as container process arguments instead of a `container run` flag. This meant the image's built-in entrypoint was never overridden. Fix: split entrypoint into --entrypoint <cmd> (before image) and remaining args (after image), matching `container run` CLI semantics. Fixes containers immediately exiting when entrypoint is set in docker-compose YAML. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…s using their names
- until now all waits always failed on 30 second timeout - user is now informed that container is running
The RuntimeStatus type was introduced by TomasLudvik's commits but doesn't exist in the container library. Removing the status tracking since it was only used for error messages.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…to build run args for services and unit tests verifying restart, init, and entrypoint ordering.\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…untime and init_image fields to Service model, docs and tests.\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…tializer\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
… streamCommand valid\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
explicitcontextualunderstanding
force-pushed
the
main
branch
from
a2b02e3 to
95d87ec
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds runtime and init_image mapping (maps to --runtime and --init-image) with docs and tests. Draft PR.