Skip to content
This repository was archived by the owner on Jul 28, 2024. It is now read-only.

Derek/20230805 image gallery#155

Open
1orZero wants to merge 60 commits into
chat-everywherefrom
derek/20230805-image-gallery
Open

Derek/20230805 image gallery#155
1orZero wants to merge 60 commits into
chat-everywherefrom
derek/20230805-image-gallery

Conversation

@1orZero
Copy link
Copy Markdown
Collaborator

@1orZero 1orZero commented Aug 9, 2023 •
edited
Loading

  • AI Image Gallery: New Image Gallery for AI Images
  • Need to monitor for any performance issues.

@vercel
Copy link
Copy Markdown

vercel Bot commented Aug 9, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
chat-everwhere ✅ Ready (Inspect) Visit Preview Sep 21, 2023 8:27pm

@1orZero
Revert "Test image tag"
bb66282 
This reverts commit 72878bf.
@1orZero 1orZero marked this pull request as ready for review August 9, 2023 10:44
@1orZero
Copy link
Copy Markdown
Collaborator Author

1orZero commented Aug 9, 2023

@patel-rushi @williamtriinh @thejackwu
Any feedback would be appreciated!

@1orZero
Copy link
Copy Markdown
Collaborator Author

1orZero commented Aug 11, 2023

@1orZero I updated the merge base to the chat-everywhere branch instead. Some merge conflicts happens since then. Looks great other than that!

Should be all good now!

@williamtriinh
Copy link
Copy Markdown

williamtriinh commented Aug 11, 2023

@1orZero I like it and the carousel transition is smooth! The only thing I would change is disabling the navigation buttons of the carousel when there's only one item.

@1orZero
Copy link
Copy Markdown
Collaborator Author

1orZero commented Aug 14, 2023

@1orZero I like it and the carousel transition is smooth! The only thing I would change is disabling the navigation buttons of the carousel when there's only one item.

Done! Ready for review again!

@patel-rushi
Copy link
Copy Markdown
Collaborator

patel-rushi commented Aug 14, 2023

@1orZero, it looks very good! Just one suggestion: consider pointing the carousel to the latest 'Variation' or 'Selected' image once generated.

@1orZero
Copy link
Copy Markdown
Collaborator Author

1orZero commented Aug 16, 2023

@1orZero, it looks very good! Just one suggestion: consider pointing the carousel to the latest 'Variation' or 'Selected' image once generated.

Good idea! I will let you know once the change is done!

@1orZero
Copy link
Copy Markdown
Collaborator Author

1orZero commented Aug 17, 2023

@1orZero, it looks very good! Just one suggestion: consider pointing the carousel to the latest 'Variation' or 'Selected' image once generated.

DONE! Please try again! @patel-rushi

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@thejackwu thejackwu Awaiting requested review from thejackwu

@patel-rushi patel-rushi Awaiting requested review from patel-rushi

1 more reviewer

@williamtriinh williamtriinh williamtriinh approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@1orZero @thejackwu @williamtriinh @patel-rushi