Fix bare except: use specific exception types#14000
Open
koteshyelamati wants to merge 2 commits into
Open
Conversation
Handle exceptions specifically when setting function signature.
Catch specific exceptions when running git command.
rkfshakti
approved these changes
Jul 23, 2026
rkfshakti
left a comment
rkfshakti
left a comment
There was a problem hiding this comment.
Clean fix. Replacing bare except: with except Exception: is the right approach — it prevents catching SystemExit/KeyboardInterrupt while still catching the expected runtime errors from inspect.signature() and run_command.
Both call sites are appropriate: inspect.signature() can raise ValueError for builtins, and run_command could raise various OSError/subprocess exceptions. Using except Exception is the minimal safe widening.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace bare
except:clauses with specific exception types:spacy/ml/callbacks.py:except Exception:(guardsinspect.signature()which can fail for Cython methods)spacy/cli/_util.py:except Exception:(guardsrun_command("git --version"))Bare
except:catchesBaseExceptionincludingSystemExitandKeyboardInterrupt.