Open
Conversation
This tells type checkers like mypy that the package has type hints. new file: spacy_layout/py.typed
This silences mypy error related to pandas usage. modified: requirements.txt
This silences a mypy error. modified: spacy_layout/layout.py
This silences a mypy error. modified: spacy_layout/layout.py
This silences a mypy error. modified: spacy_layout/layout.py
The original loop variable was used in two different conditions which altered the type. Introducing a separate variable for each condition keeps the type consisten and silences a mypy error. modified: spacy_layout/layout.py
This silences a mypy error concerning the appending of two different types to `inputs`, `TextItem` from the loop variable `text_item`, and `TableItem` from the loop varaible `table_item`. modified: spacy_layout/layout.py
This silences a mypy error regarding local variable `item` not having the attribute :meth:`export_to_dataframe`. modified: spacy_layout/layout.py
new file: pyproject.toml
Added "warn_unused_ignores" to alert devs when `srsly` is type checked. modified: pyproject.toml modified: spacy_layout/layout.py
This silences a mypy error related to the usage of `OBJ_TYPES` values in :func:`decode_obj`. modified: spacy_layout/util.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a py.typed file and puts the package in a passing state for mypy v1.19.1 and Python 3.10.11.