[eas-cli] add eas simulator:stop command#3626
Open
szdziedzic wants to merge 1 commit intographite-base/3626from
Open
[eas-cli] add eas simulator:stop command#3626szdziedzic wants to merge 1 commit intographite-base/3626from
szdziedzic wants to merge 1 commit intographite-base/3626from
Conversation
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
szdziedzic
added
the
no changelog
Graphite App
szdziedzic
force-pushed
the
04-23-_eas-cli_add_eas_simulator_stop_command
branch
from
991cedb to
4b65061
Compare
|
⏩ The changelog entry check has been skipped since the "no changelog" label is present. |
|
Subscribed to pull request
Generated by CodeMention |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 04-23-_eas-cli_add_eas_simulator_start_command #3626 +/- ##
==================================================================================
- Coverage 55.59% 55.58% -0.00%
==================================================================================
Files 856 857 +1
Lines 36703 36725 +22
Branches 7633 7670 +37
==================================================================================
+ Hits 20400 20410 +10
+ Misses 16208 14886 -1322
- Partials 95 1429 +1334 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
szdziedzic
changed the base branch from
04-23-_eas-cli_add_eas_simulator_start_command
to
graphite-base/3626
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Part of ENG-20714
Add hidden and experimental flag to stop remote simulator session
How
Call stopDeviceRunSession mutation inside this function
Test Plan
Tested manually