Skip to content

Collect staged Android emulator logs#3628

Draft
sjchmiela wants to merge 4 commits intostanley/eng-20762-stage-emulator-logcatfrom
stanley/eng-20762-collect-emulator-logcat
Draft

Collect staged Android emulator logs#3628
sjchmiela wants to merge 4 commits intostanley/eng-20762-stage-emulator-logcatfrom
stanley/eng-20762-collect-emulator-logcat

Conversation

@sjchmiela
Copy link
Copy Markdown
Contributor

Summary

  • add eas/collect_emulator_logs to stop staged logcat streams and copy settled log files into a destination directory
  • wire the Maestro function group to collect emulator logs after Maestro tests and before uploading ~/.maestro/tests
  • keep missing or already-ended logcat streams non-fatal

Why

Live log files cannot be written directly into ~/.maestro/tests because the artifact tar step can race with files that are still growing. This collects a stable snapshot only after the streams are stopped.

Test plan

  • cd packages/build-tools && yarn test collectEmulatorLogs easFunctionGroups startAndroidEmulator AndroidEmulatorUtils

@linear
Copy link
Copy Markdown

linear Bot commented Apr 23, 2026

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 23, 2026

Codecov Report

❌ Patch coverage is 80.48780% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 55.80%. Comparing base (6c0f797) to head (f0cc102).

Files with missing lines Patch % Lines
...d-tools/src/steps/functions/collectEmulatorLogs.ts 78.38% 8 Missing ⚠️
Additional details and impacted files
@@                             Coverage Diff                             @@
##           stanley/eng-20762-stage-emulator-logcat    #3628      +/-   ##
===========================================================================
+ Coverage                                    55.50%   55.80%   +0.30%     
===========================================================================
  Files                                          856      853       -3     
  Lines                                        36826    36621     -205     
  Branches                                      7646     7609      -37     
===========================================================================
- Hits                                         20437    20432       -5     
+ Misses                                       16294    16093     -201     
- Partials                                        95       96       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sjchmiela sjchmiela force-pushed the stanley/eng-20762-stage-emulator-logcat branch from 93e6a3d to 7945c7d Compare April 23, 2026 15:51
@sjchmiela sjchmiela force-pushed the stanley/eng-20762-collect-emulator-logcat branch from 0ac40a4 to ce5ca73 Compare April 23, 2026 15:53
@sjchmiela sjchmiela force-pushed the stanley/eng-20762-stage-emulator-logcat branch from 7945c7d to 6c0f797 Compare April 23, 2026 15:56
@sjchmiela sjchmiela force-pushed the stanley/eng-20762-collect-emulator-logcat branch from ce5ca73 to 8f7e23d Compare April 23, 2026 15:57
@sjchmiela sjchmiela force-pushed the stanley/eng-20762-collect-emulator-logcat branch from 8f7e23d to fc6c828 Compare April 23, 2026 16:42
@sjchmiela sjchmiela added the no changelog PR that doesn't require a changelog entry label Apr 23, 2026
@github-actions
Copy link
Copy Markdown

⏩ The changelog entry check has been skipped since the "no changelog" label is present.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no changelog PR that doesn't require a changelog entry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant