Collect staged Android emulator logs#3628
Draft
sjchmiela wants to merge 4 commits intostanley/eng-20762-stage-emulator-logcatfrom
Draft
Collect staged Android emulator logs#3628sjchmiela wants to merge 4 commits intostanley/eng-20762-stage-emulator-logcatfrom
sjchmiela wants to merge 4 commits intostanley/eng-20762-stage-emulator-logcatfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## stanley/eng-20762-stage-emulator-logcat #3628 +/- ##
===========================================================================
+ Coverage 55.50% 55.80% +0.30%
===========================================================================
Files 856 853 -3
Lines 36826 36621 -205
Branches 7646 7609 -37
===========================================================================
- Hits 20437 20432 -5
+ Misses 16294 16093 -201
- Partials 95 96 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
93e6a3d to
7945c7d
Compare
0ac40a4 to
ce5ca73
Compare
7945c7d to
6c0f797
Compare
ce5ca73 to
8f7e23d
Compare
8f7e23d to
fc6c828
Compare
|
⏩ The changelog entry check has been skipped since the "no changelog" label is present. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
eas/collect_emulator_logsto stop staged logcat streams and copy settled log files into a destination directory~/.maestro/testsWhy
Live log files cannot be written directly into
~/.maestro/testsbecause the artifact tar step can race with files that are still growing. This collects a stable snapshot only after the streams are stopped.Test plan
cd packages/build-tools && yarn test collectEmulatorLogs easFunctionGroups startAndroidEmulator AndroidEmulatorUtils