[website] Fix test failing locally#681
Merged
Merged
Conversation
This was referenced May 8, 2026
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
e7e34f6 to
92ad220
Compare
92ad220 to
5fbee17
Compare
2dc6a9c to
a85a52c
Compare
5fbee17 to
12fcfeb
Compare
12fcfeb to
711ee44
Compare
c81b819 to
012c054
Compare
012c054 to
a3fcfaa
Compare
byCedric
approved these changes
May 20, 2026
3ab9305 to
9c00c29
Compare
a3fcfaa to
3644aa4
Compare
9c00c29 to
c941cf4
Compare
3644aa4 to
1ad7983
Compare
1ad7983 to
2732168
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Why
FileListEntry.test.tsx fails locally but passes on Linux CI. The test indirectly captures KeyMap.Meta's integer value, which KeybindingsManager.tsx derives from navigator.platform at module load. Jest's node test environment historically had no globalThis.navigator, so the snapshot was recorded with the non-Mac value. Node 21+ now exposes a built-in globalThis.navigator whose platform reflects the host OS, so on Macs the the snapshot mismatches.
How
Stub globalThis.navigator injest/unit.setup.js with a fixed non-Mac value so snapshot stays deterministic across hosts.
Test Plan
Tests pass.