Fix: throw error when credentials=true with origin='*'#413
Open
jiafeimao0p wants to merge 1 commit intoexpressjs:masterfrom
Open
Fix: throw error when credentials=true with origin='*'#413jiafeimao0p wants to merge 1 commit intoexpressjs:masterfrom
jiafeimao0p wants to merge 1 commit intoexpressjs:masterfrom
Conversation
According to CORS specification, using wildcard '*' in Access-Control-Allow-Origin header is forbidden when Access-Control-Allow-Credentials is set to true. This fix adds validation that throws an error when both options are set, following the fetch spec: https://fetch.spec.whatwg.org/#cors-protocol-and-credentials Fixes expressjs#333
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
According to the CORS specification, using wildcard
*inAccess-Control-Allow-Originheader is forbidden whenAccess-Control-Allow-Credentialsis set totrue.This fix adds validation that throws an error when both options are set, following the fetch spec: https://fetch.spec.whatwg.org/#cors-protocol-and-credentials
Problem
Currently, the cors middleware allows setting
credentials: truewithorigin: '*', which violates the CORS standard and causes browsers to reject the request.Solution
Added a
validateCredentialsAndOrigin()function that throws an error when bothcredentialsistrueandoriginis'*'.Changes
lib/index.js: AddedvalidateCredentialsAndOrigin()function and call it in the cors middlewaretest/test.js: Added test cases for the new validationTesting
Added test cases:
credentials=trueandorigin='*'origin='*'works normally whencredentials=falseFixes #333