fix: add form-action and frame-ancestors to CSP header in redirects#242
Open
Sumit-Mayani wants to merge 1 commit intoexpressjs:masterfrom
Open
fix: add form-action and frame-ancestors to CSP header in redirects#242Sumit-Mayani wants to merge 1 commit intoexpressjs:masterfrom
Sumit-Mayani wants to merge 1 commit intoexpressjs:masterfrom
Conversation
default-src does not cover form-action or frame-ancestors directives per CSP spec, so omitting them allows unrestricted behavior for those vectors. Closes expressjs#187 Assisted-by AI: Claude (Anthropic)
Sumit-Mayani
force-pushed
the
fix/csp-missing-directives
branch
from
2f5570f to
767d7ba
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #187
Problem
The redirect response sets
Content-Security-Policy: default-src 'none', but per the CSP spec,form-actionandframe-ancestorsdirectives do not inherit fromdefault-src. Omitting them is equivalent to allowing anything for those vectors.Fix
Add the two missing directives explicitly:
Testing
Updated the existing CSP test to assert the full header value. All 92 tests pass.