client: cli: allow disable keepalive_continuous via CLI#487
Draft
kp-antonio-yang wants to merge 1 commit into
Draft
client: cli: allow disable keepalive_continuous via CLI#487kp-antonio-yang wants to merge 1 commit into
kp-antonio-yang wants to merge 1 commit into
Conversation
|
Code coverage summary for 6d1e7b9: ✅ Region coverage 69% passes |
kp-antonio-yang
force-pushed
the
kl-interface
branch
4 times, most recently
from
July 24, 2026 02:56
5a322af to
1290c5c
Compare
Previously the keepalive is enabled by default, and the option only provide a boolean option, `--keepalive-continuous`, to enable it again. By modify to `--disable-keepalive-continuous`, user can easy to turn off the keepalive feature from cli.
kp-antonio-yang
force-pushed
the
kl-interface
branch
from
July 24, 2026 03:04
1290c5c to
dc7a161
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
client: cli: allow disable keepalive_continuous via CLI
Description
Renames the
keepalive_continuousconfig field todisable_keepalive_continuousand exposes it as a--disable-keepalive-continuousCLI flag. The internalcontinuous_keepalivevalue is derived by negating this field, so the runtime behaviour is unchanged when the flag is not set.Motivation and Context
Continuous keepalive is enabled by default. The previous field name (
keepalive_continuous) implied an opt-in, but since the feature is always on there was no CLI way to turn it off. Inverting the flag to--disable-keepalive-continuousmakes the default state implicit and gives operators a clear opt-out when they need to disable the feature.Why not
--keepalive-continuous=false?The
LW_CLIENT_*environment variable convention is the reason. WhenLW_CLIENT_KEEPALIVE_CONTINUOUSis unset, it is generally interpreted as false, which would inadvertently disable continuous keepalive. For a feature that is enabled by default, a--disable-*flag is the more correct and predictable design.How Has This Been Tested?
Defaultimpl still producescontinuous_keepalive = true(i.e.disable_keepalive_continuous = false).--disable-keepalive-continuouson the CLI setscontinuous_keepalive = falsein the resultingClientConfig.Types of changes
Checklist:
main