Skip to content

Add priority class name configuration to deployment#74

Open
rudxde wants to merge 1 commit intoexternal-secrets:mainfrom
rudxde:add-priority-class-name-helm-value
Open

Add priority class name configuration to deployment#74
rudxde wants to merge 1 commit intoexternal-secrets:mainfrom
rudxde:add-priority-class-name-helm-value

Conversation

@rudxde
Copy link

@rudxde rudxde commented Feb 17, 2026

Problem Statement

What is the problem you're trying to solve?

The priorityClassName is not configurable in the helm chart

Related Issue

Fixes #...

Proposed Changes

How do you like to solve the issue and why?

adding the priorityClassName value to the deplyoment and values. Keept empty to not break or change active

Checklist

  • I have read the contribution guidelines
  • All commits are signed with git commit --signoff
  • My changes have reasonable test coverage
  • [~] All tests pass with make test -> just helm unittest .
  • I ensured my PR is ready for review with make reviewable

Summary

Adds priorityClassName as a configurable value for the Kubernetes Deployment in the Helm chart. The feature is optional with an empty default value to preserve backward compatibility.

Changes

Helm Chart Configuration:

  • values.yaml: Added priorityClassName configuration parameter with empty default
  • templates/deployment.yaml: Added conditional rendering of priorityClassName in the pod spec when configured

Tests:

  • tests/deployment_test.yaml: Added test cases verifying that priorityClassName is absent by default and correctly set when configured

Signed-off-by: rudxde <info@michael-rudolph.dev>
@coderabbitai
Copy link

coderabbitai bot commented Feb 17, 2026

No actionable comments were generated in the recent review. 🎉


Walkthrough

Adds support for configuring a priority class name in the bitwarden-sdk-server Helm chart through a new optional parameter, including template updates and corresponding test coverage.

Changes

Cohort / File(s) Summary
Priority Class Support
deploy/charts/bitwarden-sdk-server/templates/deployment.yaml, deploy/charts/bitwarden-sdk-server/values.yaml, deploy/charts/bitwarden-sdk-server/tests/deployment_test.yaml
Adds optional priorityClassName field to pod spec with conditional rendering, introduces new configuration option in values.yaml, and includes test cases verifying default absence and custom priority class assignment.

Tip

Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

- equal:
path: spec.template.spec.dnsConfig.options[0].value
value: "2"
- it: Should not have Priority Class Name set by default
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@Skarlso
Copy link
Collaborator

Skarlso commented Feb 17, 2026

@rudxde Could you please sign your commits? :) Thanks 🙇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

2 participants