Add priority class name configuration to deployment#74
Open
rudxde wants to merge 1 commit intoexternal-secrets:mainfrom
Open
Add priority class name configuration to deployment#74rudxde wants to merge 1 commit intoexternal-secrets:mainfrom
rudxde wants to merge 1 commit intoexternal-secrets:mainfrom
Conversation
Signed-off-by: rudxde <info@michael-rudolph.dev>
|
No actionable comments were generated in the recent review. 🎉 WalkthroughAdds support for configuring a priority class name in the bitwarden-sdk-server Helm chart through a new optional parameter, including template updates and corresponding test coverage. Changes
Tip Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Skarlso
reviewed
Feb 17, 2026
| - equal: | ||
| path: spec.template.spec.dnsConfig.options[0].value | ||
| value: "2" | ||
| - it: Should not have Priority Class Name set by default |
Skarlso
approved these changes
Feb 17, 2026
Collaborator
|
@rudxde Could you please sign your commits? :) Thanks 🙇 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem Statement
What is the problem you're trying to solve?
The priorityClassName is not configurable in the helm chart
Related Issue
Fixes #...
Proposed Changes
How do you like to solve the issue and why?
adding the priorityClassName value to the deplyoment and values. Keept empty to not break or change active
Checklist
git commit --signoffmake test-> justhelm unittest .make reviewableSummary
Adds
priorityClassNameas a configurable value for the Kubernetes Deployment in the Helm chart. The feature is optional with an empty default value to preserve backward compatibility.Changes
Helm Chart Configuration:
values.yaml: AddedpriorityClassNameconfiguration parameter with empty defaulttemplates/deployment.yaml: Added conditional rendering ofpriorityClassNamein the pod spec when configuredTests:
tests/deployment_test.yaml: Added test cases verifying thatpriorityClassNameis absent by default and correctly set when configured