fix(ci): Use ditto instead of zip for Sparkle update archive#111
Merged
Conversation
zip -r dereferences symlinks in Sparkle.framework's versioned directory structure (Versions/Current -> B, top-level -> Versions/Current/*), storing 3x duplicate files. When Sparkle extracts this ZIP, codesign --verify fails with "bundle format is ambiguous" and the update is rejected. ditto preserves symlinks and macOS extended attributes. Also adds sparkle-updater skill documenting the full update pipeline, known pitfalls, and verification checklist. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
zip -rwithditto -c -k --keepParentfor creating the Sparkle update ZIP archive in the release workflowsparkle-updaterskill documenting the full update pipeline, known pitfalls, and verification checklistRoot Cause
zip -rdereferences symlinks inSparkle.framework's versioned directory structure (Versions/Current -> B, top-level items →Versions/Current/*). This creates a ZIP with:When Sparkle extracts this ZIP on the user's machine,
codesign --verifyfails with "bundle format is ambiguous" and the update is rejected.Proof
Downloaded
TermQ-0.7.0-beta.7.zip, extracted, rancodesign --verify --deep --strict:Local comparison:
zip -routput: 2.8MB, no symlinks, 3x file copiesdittooutput: 940KB, symlinks preservedWhy Previous Fixes Didn't Help
--deepbreaking XPC trust chainAll were real bugs, but none touched the ZIP creation step where the actual failure occurs.
Test plan
v0.7.0-beta.8, monitor release workflowls -lashows symlinks inSparkle.framework/codesign --verify --deep --strictpasses on extracted app🤖 Generated with Claude Code