feat(harness): migrate ynh install/uninstall/export to CommandRunnerSheet#316
Merged
Conversation
…heet Replaces transient terminal cards for ynh install, ynh uninstall, and ynd export with CommandRunnerSheet-backed progress sheets. The old approach spawned a real terminal card that auto-ran a shell command — sheets give us structured success/failure state, a retry button on failure, and cleaner lifecycle without the tab management overhead. HarnessLifecycleCoordinator drops installCardIDs, uninstallCardIDs, and handleTransientSessionExit entirely. ContentView drops the termqDirectSessionExited notification handler and gains three .sheet modifiers for the new flow. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
eyelock
force-pushed
the
feat/ynh-ops-to-sheet
branch
from
6a215e8 to
30d8f99
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces transient terminal cards for
ynh install,ynh uninstall, andynd exportwithCommandRunnerSheet-backed progress sheets. The old approach spawned a real terminal card that auto-ran a shell command and monitored exit viatermqDirectSessionExitednotifications — sheets give structured success/failure state, a retry button on failure, and cleaner lifecycle without the tab management overhead.Changes
HarnessInstallProgressSheet— runsynh installwith live output; refreshes harness list on successHarnessUninstallSheet— runsynh uninstall <id>with live output; clears YNHPersistence associations on successHarnessExportSheet— runsynd export <path> -o <dir>with live outputHarnessLifecycleCoordinator— dropsinstallCardIDs,uninstallCardIDs,handleTransientSessionExit, and all transient card spawning; gains sheet-state properties for the three new flowsContentView— dropstermqDirectSessionExitednotification handler; gains three.sheetmodifiers;onDeleteLocal: nil(sidebar falls back toonUninstall, which handles the direct-delete path for non-YNH harnesses)Testing
ynh/yndnot found: error message shown, no crash🤖 Generated with Claude Code