fix(terminal): enable drag-to-select in tmux control mode#325
Merged
Conversation
ControlModeTerminalView is a bare TerminalView subclass and never had the allowMouseReporting toggle that lets users select text in panes whose inner app has mouse mode on (e.g. Claude Code TUI). Without it, SwiftTerm's mouseDragged short-circuits on the inner app's mouse mode and feedPrepare() clears any nascent selection on every output burst — visible as "can't select while Claude is thinking" in tmux-control panes. Extract the drag-to-select logic (event monitors, allowMouseReporting toggle, auto-scroll timer, linefeed/selectionChanged/scrolled overrides) from TermQTerminalView into a new TerminalSelectionDragController. TermQTerminalView and ControlModeTerminalView each own one and forward their three SwiftTerm overrides into it. Behavior in Direct and tmux-attach (which both use TermQTerminalView) is unchanged; tmux-control panes now get the same drag-to-select support. Composition rather than a shared base class because TermQTerminalView inherits from LocalProcessTerminalView and ControlModeTerminalView from TerminalView — no common Swift ancestor we can extend. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ControlModeTerminalViewis a bareTerminalViewsubclass and never had theallowMouseReportingtoggle fromTermQTerminalView. Without it, SwiftTerm'smouseDraggedshort-circuits on the inner TUI's mouse mode andfeedPrepare()clears any nascent selection on every output burst — visible as "can't select text while Claude is thinking" in tmux-control panes.allowMouseReportingtoggle, auto-scroll timer,linefeed/selectionChanged/scrolledoverride behavior) fromTermQTerminalViewinto a newTerminalSelectionDragController.TermQTerminalViewandControlModeTerminalVieweach own one and forward their three SwiftTerm overrides into it.TermQTerminalViewinherits fromLocalProcessTerminalViewandControlModeTerminalViewfromTerminalView— no common Swift ancestor we can extend.Test plan
swift package clean && make check— clean build, lint clean (no new violations), format clean, tests pass🤖 Generated with Claude Code